Re: [PATCH V10 05/14] xen/pvh: balloon and grant changes.

[Konrad Rzeszutek Wilk]

> > > > > These changes to balloon.c are similar to my patch but:
> > > > > 
> > > > > - they don't prevent set_phys_to_machine from being called by
> > > > > increase_reservation for auto_translated guests
> > > > 
> > > > <nods>
> > > > > 
> > > > > - they don't prevent wasteful balloon_scratch_page from being allocated
> > > > > for auto_translated guests
> > > > 
> > > > <nods>
> > > > > 
> > > > > I think that it would be best to take my patch instead.
> > > > 
> > > > Lets focus the review on your patch then and have it part of this
> > > > series. 
> > > 
> > > OK, but keep in mind that Xen on ARMv8 is currently broken without that
> > > patch.
> > 
> > Hm. We could have another patch to just disable BALLOON on ARMv8 :-)
> > 
> > The question you have to ask - if your patch causes regression are you
> > OK tracking/fixing it over the holidays :-) If yes, then yes - we can
> > put that in v3.13-rc3 to make it work properly on ARMv8.
> 
> Damn, that was a good argument.
> After thinking more about it, I think that I, or a member of my team,
> can actually fix possible bugs during the holidays. Especially
> considering that the patch doesn't alter the behavior of PV guests.
> 
> So in short, yes :)

Great <evil laughther>! Could you repost it with the description changes?
Or if you OK with the changes I had proposed - just tell me "yes" and I will
alter it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/