Re: [PATCH v3 5/6] ARM: pinctrl: Add Broadcom Capri pinctrl driver

From: Mark Brown
Date: Fri Dec 13 2013 - 05:23:33 EST


On Thu, Dec 12, 2013 at 09:54:50PM +0100, Linus Walleij wrote:

> This is a reimplementation of regmap for MMIO.
> See drivers/base/regmap/regmap-mmio.c
> Notice how regmap_update_bits() is used throughout the
> kernel.

> If you want to do this, use regmap.

Or if this is very performance sensitive (which I'd not expect for
pinctrl) there's a helper in review at the minute which just uses a
spinlock.

Attachment: signature.asc
Description: Digital signature