Re: [PATCH] drm/bochs: new driver

From: Stefan Lippers-Hollmann
Date: Thu Dec 12 2013 - 22:30:52 EST


Hi

On Thursday 12 December 2013, Gerd Hoffmann wrote:
> DRM driver for (virtual) vga cards using the bochs dispi
> interface, such as the qemu standard vga (qemu -vga std).
>
> Don't bother supporting anything but 32bpp for now, even
> though the virtual hardware is able to do that.
>
> Known issue: mmap(/dev/fb0) doesn't work.
>
> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> ---
[â]
> diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
> new file mode 100644
> index 0000000..afe104f
> --- /dev/null
> +++ b/drivers/gpu/drm/bochs/bochs_mm.c
[â]
> +int bochs_gem_create(struct drm_device *dev, u32 size, bool iskernel,
> + struct drm_gem_object **obj)
> +{
> + struct bochs_bo *bochsbo;
> + int ret;
> +
> + *obj = NULL;
> +
> + size = roundup(size, PAGE_SIZE);
[â]

Using roundup() this way will fail to build in 32 bit architectures/
i386:

ERROR: "__udivdi3" [drivers/gpu/drm/bochs/bochs-drm.ko] undefined!
ERROR: "__umoddi3" [drivers/gpu/drm/bochs/bochs-drm.ko] undefined!

[drm/bochs works pretty nicely for me on amd64]

Regards
Stefan Lippers-Hollmann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/