Re: [patch net-next v2] ipv6: log autoconfiguration failures

[Hannes Frederic Sowa]

On Thu, Dec 12, 2013 at 01:24:41PM -0500, David Miller wrote:
> From: Vlad Yasevich <vyasevich@xxxxxxxxx>
> Date: Thu, 12 Dec 2013 12:58:18 -0500
> 
> > On 12/12/2013 12:22 PM, David Miller wrote:
> >> Give it statistics just like we have for every other kind of similar
> >> event.
> > 
> > The fact that link-local address could not be generated for a specific
> > device type does not lend itself well to counting.  There is no way
> > from to tell from the counter which device does not support IPv6 autoconfig.
> 
> If the statistic is per-device, which I recommended it be implemented as,
> you indeed can.
> 
> And I do not buy the argument that this is "useless" because the admin
> is just going to kill the interface and create a new one.  When you
> notice there is a problem, you look at the statistics before doing
> that!

Granted.

IMHO both ways are fine with a slight opionion to counters being overkill. ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/