Re: [PATCH] rt-tests: hackbench: fix for uninitialized start time

From: Clark Williams
Date: Thu Dec 12 2013 - 10:14:36 EST


On Thu, 12 Dec 2013 16:47:19 +0200
Ciprian Barbu <ciprian.barbu@xxxxxxxxxx> wrote:

> Hello,
>
> While playing around with hackbench I discovered that I would sometimes
> get an enormous time reported, even if the run time would be less than a
> second or so. The problem was that the struct timeval start was not
> initialized until after all children have been created. But if the
> program receives a signal before this is done, the start time is left
> uninitialized.
>
> I propose that in such situations an error message be displayed, like
> the following patch does.
>
> Please let me know if this is acceptable.
>
> Regards,
> /Ciprian

Looks good to me. I've pulled it in for the next release.

Clark

Attachment: signature.asc
Description: PGP signature