Re: [PATCH] gpu: host1x: clk_round_rate() can return a zero uponerror

From: Thierry Reding
Date: Thu Dec 12 2013 - 06:05:11 EST


On Mon, Dec 09, 2013 at 06:00:12PM -0800, Paul Walmsley wrote:
>
> Treat both negative and zero return values from clk_round_rate() as
> errors. This is needed since subsequent patches will convert
> clk_round_rate()'s return value to be an unsigned type, rather than a
> signed type, since some clock sources can generate rates higher than
> (2^31)-1 Hz.
>
> Eventually, when calling clk_round_rate(), only a return value of zero
> will be considered a error. All other values will be considered valid
> rates. The comparison against values less than 0 is kept to preserve
> the correct behavior in the meantime.
>
> Signed-off-by: Paul Walmsley <pwalmsley@xxxxxxxxxx>
> Cc: Mikko Perttunen <mperttunen@xxxxxxxxxx>
> Cc: Arto Merilainen <amerilainen@xxxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Terje BergstrÃm <tbergstrom@xxxxxxxxxx>
> ---
> Applies on v3.13-rc3. See also:
>
> http://marc.info/?l=linux-arm-kernel&m=138542591313620&w=2
>
> drivers/gpu/drm/tegra/hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature