Re: [PATCH v5 09/14] efi: passing kexec necessary efi data viasetup_data

[Dave Young]

> > >  
> > > +void __init parse_efi_setup(u64 phys_addr)
> > > +{
> > > +	struct setup_data *sd;
> > > +
> > > +	if (!efi_enabled(EFI_64BIT)) {
> > > +		pr_warn("SETUP_EFI not supported on 32-bit\n");
> > > +		return;
> > > +	}
> > 
> > Shouldn't this function be in two versions in efi_64.c and efi_32.c?
> > This way you don't need this check with cryptic printk message.
> 
> Ok, will update.

Rethink about this issue, moving them to efi_$(BITS).c I need move the
efi_setup from a static variable to an extern, It looks not worth.

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/