Re: [PATCH 1/3] wait-simple: Introduce the simple waitqueueimplementation

From: Steven Rostedt
Date: Wed Dec 11 2013 - 20:58:15 EST


On Wed, 11 Dec 2013 20:06:37 -0500
Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote:

> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> The wait_queue is a swiss army knife and in most of the cases the
> full complexity is not needed. Here we provide a slim version, as
> it lowers memory consumption and runtime overhead.
>
> The concept originated from RT, where waitqueues are a constant
> source of trouble, as we can't convert the head lock to a raw
> spinlock due to fancy and long lasting callbacks.
>
> The smp_mb() was added (by Steven Rostedt) to fix a race condition
> with swait wakeups vs. adding items to the list.

For this part, you can also add my:

Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

I'll also look at these and test them a bit against mainline.

Thanks for doing this!

-- Steve

>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> [PG: carry forward from multiple v3.10-rt patches to mainline, align
> function names with "normal" wait queue names, update commit log.]
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/