Re: [PATCH 2/2] mm: blk-mq: uses page->list incorrectly

From: David Rientjes
Date: Wed Dec 11 2013 - 17:47:50 EST


On Wed, 11 Dec 2013, Dave Hansen wrote:

>
> From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>
> 'struct page' has two list_head fields: 'lru' and 'list'.
> Conveniently, they are unioned together. This means that code
> can use them interchangably, which gets horribly confusing.
>
> The blk-mq made the logical decision to try to use page->list.
> But, that field was actually introduced just for the slub code.
> ->lru is the right field to use outside of slab/slub.
>
> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/