Re: [PATCH v0 54/71] perf script: Always allow fields 'addr' and'cpu' for itrace

From: David Ahern
Date: Wed Dec 11 2013 - 14:41:27 EST


On 12/11/13, 5:37 AM, Alexander Shishkin wrote:
From: Adrian Hunter <adrian.hunter@xxxxxxxxx>

If a file contains Instruction Tracing data then always allow
fields 'addr' and 'cpu' to be selected as options for perf
script. This is necessary because Instruction Trace decoding
may synthesize events with that information.

Why hardcode it? If it is present and the user opts for it then it will be printed. Why is the itrace check needed?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/