Re: 50 Watt idle power regression bisected to Linux-3.10

From: Peter Zijlstra
Date: Wed Dec 11 2013 - 11:44:57 EST


On Wed, Dec 11, 2013 at 04:09:11PM +0100, Ingo Molnar wrote:
>
> * Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> > On Wed, 11 Dec 2013, Ingo Molnar wrote:
> > >
> > > Another thing that is required I think is to issue a write barrier
> > > before CLFLUSH instruction. By my (possibly incorrect ...) reading of
> > > the documentation CLFLUSH does not appear to be ordered (at all), so
> > > it might execute before the modification to the affected memory?
> >
> > We already have a write barrier in the code which modifies
> > current_thread_info()->flags.
>
> Which code is that, could you please cite it? (I tried finding it but
> my grep-fu failed me.)

current_set_polling_and_test().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/