Re: [patch net-next] ipv6: log autoconfiguration failures

[David Miller]

From: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
Date: Mon,  9 Dec 2013 17:26:48 +0100

> If ipv6 auto-configuration does not work, currently it's hard
> to track what's going on. This change adds log messages
> (at debug level) on every code path where ipv6 autoconf fails.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>

Add statistics, those are more globally useful.

> +		pr_debug("IPv6 addrconf: %s: address length %d != %s\n",
> +				dev->name, dev->addr_len, "ETH_ALEN");

And this is not indented correctly, the arguments on lines after the
first must line up exactly to the column after the openning parenthesis
of the function call.

The idea isn't to use just TABs until you think it looks nice, rather
you should use the appropriate number of SPACE and TAB characters
necessary to reach the exact column.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/