Re: [PATCH v4 01/12] sched/numa: fix set cpupid on page migrationtwice against thp

[Naoya Horiguchi]

On Tue, Dec 10, 2013 at 05:19:24PM +0800, Wanpeng Li wrote:
> commit 7851a45cd3 (mm: numa: Copy cpupid on page migration) copy over
> the cpupid at page migration time, there is unnecessary to set it again
> in function migrate_misplaced_transhuge_page, this patch fix it.
> 
> Acked-by: Mel Gorman <mgorman@xxxxxxx>
> Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>
> Signed-off-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>

> ---
>  mm/migrate.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index bb94004..fdb70f7 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1736,8 +1736,6 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm,
>  	if (!new_page)
>  		goto out_fail;
>  
> -	page_cpupid_xchg_last(new_page, page_cpupid_last(page));
> -
>  	isolated = numamigrate_isolate_page(pgdat, page);
>  	if (!isolated) {
>  		put_page(new_page);
> -- 
> 1.7.7.6
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/