Re: [PATCH v4 07/12] sched/numa: fix set cpupid on page migrationtwice against normal page

[Naoya Horiguchi]

On Tue, Dec 10, 2013 at 05:19:30PM +0800, Wanpeng Li wrote:
> commit 7851a45cd3 (mm: numa: Copy cpupid on page migration) copy over
> the cpupid at page migration time, there is unnecessary to set it again
> in function alloc_misplaced_dst_page, this patch fix it.
> 
> Signed-off-by: Wanpeng Li <liwanp@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>

> ---
>  mm/migrate.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/migrate.c b/mm/migrate.c
> index b1b6663..508cde4 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1557,8 +1557,6 @@ static struct page *alloc_misplaced_dst_page(struct page *page,
>  					  __GFP_NOMEMALLOC | __GFP_NORETRY |
>  					  __GFP_NOWARN) &
>  					 ~GFP_IOFS, 0);
> -	if (newpage)
> -		page_cpupid_xchg_last(newpage, page_cpupid_last(page));
>  
>  	return newpage;
>  }
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/