Re: [PATCH v3 08/15] mfd: menelaus: Pass menelaus_chip pointer toadd/remove irq functions
From: Felipe Balbi
Date: Tue Dec 10 2013 - 11:34:11 EST
On Tue, Dec 10, 2013 at 09:00:21AM +0000, Lee Jones wrote:
> On Mon, 09 Dec 2013, Felipe Balbi wrote:
>
> > Those functions are static and can receive a menelaus_chip pointer very
> > easily.
> >
> > Tested-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > ---
> > drivers/mfd/menelaus.c | 57 ++++++++++++++++++++++++++------------------------
> > 1 file changed, 30 insertions(+), 27 deletions(-)
>
> Same here. I think this should be done in one fell swoop.
then it would become a much, much larger patch which would become a pain
to review.
--
balbi
Attachment:
signature.asc
Description: Digital signature