Re: [PATCH v2 06/16] wl1251: configure hardware en-/decryption formonitor mode

[Pavel Machek]

Hi!


> --- a/drivers/net/wireless/ti/wl1251/tx.c
> +++ b/drivers/net/wireless/ti/wl1251/tx.c
> @@ -287,6 +287,9 @@ static int wl1251_tx_frame(struct wl1251 *wl, struct sk_buff *skb)
>  	info = IEEE80211_SKB_CB(skb);
>  
>  	if (info->control.hw_key) {
> +		if (unlikely(wl->monitor_present))
> +			return -1;
> +


This function seems to use 0/-errno convention. So probably "return
-EINVAL"?

With that fixed:

Reviewed-by: Pavel Machek <pavel@xxxxxx>

Thanks,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/