Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak iniscsi_boot_destroy_kset()

From: Konrad Rzeszutek Wilk
Date: Mon Dec 09 2013 - 16:31:46 EST


On Mon, Dec 09, 2013 at 05:37:11PM +0800, Ethan Zhao wrote:
> From: "Ethan Zhao" <ethan.kernel@xxxxxxxxx>
>
> Load and unload iscsi_ibft module will cause kernel memory leak, fix it
> in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset().
>

Is there a stack trace?
> Signed-off-by: Ethan Zhao <ethan.kernel@xxxxxxxxx>
> ---
> drivers/scsi/iscsi_boot_sysfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/iscsi_boot_sysfs.c b/drivers/scsi/iscsi_boot_sysfs.c
> index 14c1c8f..680bf6f 100644
> --- a/drivers/scsi/iscsi_boot_sysfs.c
> +++ b/drivers/scsi/iscsi_boot_sysfs.c
> @@ -490,5 +490,6 @@ void iscsi_boot_destroy_kset(struct iscsi_boot_kset *boot_kset)
> iscsi_boot_remove_kobj(boot_kobj);
>
> kset_unregister(boot_kset->kset);
> + kfree(boot_kset);
> }
> EXPORT_SYMBOL_GPL(iscsi_boot_destroy_kset);
> --
> 1.8.3.4 (Apple Git-47)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/