Re: [PATCH 1/2] PCI: pcibus address to resource converting take businstead of dev

From: Bjorn Helgaas
Date: Mon Dec 09 2013 - 16:07:26 EST


On Mon, Dec 9, 2013 at 1:47 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Mon, Dec 9, 2013 at 12:43 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> On Mon, Dec 09, 2013 at 12:03:18PM -0800, Yinghai Lu wrote:
>>> On Mon, Dec 9, 2013 at 11:21 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>>> > On Mon, Dec 9, 2013 at 9:52 AM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>>> >>
>>> >> Ugh. Why would we add new functions with "__" prefixes? There are
>>> >> only a handful of callers to pcibios_bus_to_resource() and
>>> >> pcibios_resource_to_bus(). We can just change them to supply a
>>> >> "struct pci_bus *" directly. That's a better match for how the
>>> >> hardware works anyway.
>>> >
>>>
>>> Please double check if you are happy with the change.
>>> Hope that will not update stable tree maintainer guys.
>>
>> What do you mean by this?
>
> Do not want to change too much code, to upset stable tree maintainers.
>
>>
>> How is this a -stable kernel patch?
>
> We have stable patch that will need use the new function.
>
> [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

Let's not get too far ahead of ourselves here. I don't like this
patch even for upstream, so we don't need to worry about -stable quite
yet.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/