Re: [PATCH 35/41] tile: Replace __get_cpu_var uses

[Chris Metcalf]

On 12/3/2013 6:33 PM, Christoph Lameter wrote:
> __get_cpu_var() is used for multiple purposes in the kernel source. One of
> them is address calculation via the form &__get_cpu_var(x).  This calculates
> the address for the instance of the percpu variable of the current processor
> based on an offset.
>
> [...]
>
> Cc: Chris Metcalf <cmetcalf@xxxxxxxxxx>
> Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>

Acked-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>

Except for a comment typo:

>  /*
>   * Read the set of maskable interrupts.
> - * We avoid the preemption warning here via __this_cpu_ptr since even
> + * We avoid the preemption warning here via raw_cpu_ptr since even
>   * if irqs are already enabled, it's harmless to read the wrong cpu's
>   * enabled mask.
>   */
>  #define arch_local_irqs_enabled() \
> -	(*__this_cpu_ptr(&interrupts_enabled_mask))
> +	raw_cpu_read(interrupts_enabled_mask)

Should be raw_cpu_read() in the comment.

I assume you are planning to submit these through your own tree, not the arch trees?

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/