Re: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio

From: Yinghai Lu
Date: Mon Dec 09 2013 - 15:45:08 EST


On Mon, Dec 9, 2013 at 12:20 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:

> Yes, I agree. I didn't say it would be simple. The quick fix would
> be easy for now, but adding nonsensical code makes our lives harder
> long into the future.

If the old kernel is working, and user update kernel then we should
not request them to append "pci=realloc=off" for booting.

other user that would have "pci=realloc=on" works, they could always
keep that.

For now, we just reduce auto enable scope, as very beginning we are doing
that esp for SRIOV..., and now SRIOV would require huge range esp when
num_VF could be 64. we are easy to hit the case that realloc code mess up
the bios allocation when there is not above 4G 64bit mmio.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/