Re: [PATCH v2 3/7] mm/mempolicy: correct putback method for isolatepages if failed

From: Rafael Aquini
Date: Mon Dec 09 2013 - 11:41:43 EST


On Mon, Dec 09, 2013 at 06:10:44PM +0900, Joonsoo Kim wrote:
> queue_pages_range() isolates hugetlbfs pages and putback_lru_pages() can't
> handle these. We should change it to putback_movable_pages().
>
> Naoya said that it is worth going into stable, because it can break
> in-use hugepage list.
>
> Cc: <stable@xxxxxxxxxxxxxxx> # 3.12
> Reviewed-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index eca4a31..6d04d37 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1318,7 +1318,7 @@ static long do_mbind(unsigned long start, unsigned long len,
> if (nr_failed && (flags & MPOL_MF_STRICT))
> err = -EIO;
> } else
> - putback_lru_pages(&pagelist);
> + putback_movable_pages(&pagelist);
>
> up_write(&mm->mmap_sem);
> mpol_out:

Acked-by: Rafael Aquini <aquini@xxxxxxxxxx>


> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/