Re: [PATCHSET 00/14] tools lib traceevent: Get rid of *die() callsfrom parse-filter.c

From: Steven Rostedt
Date: Mon Dec 09 2013 - 11:41:11 EST


On Mon, 9 Dec 2013 11:47:18 +0100
Jiri Olsa <jolsa@xxxxxxxxxx> wrote:

> On Mon, Dec 09, 2013 at 02:33:57PM +0900, Namhyung Kim wrote:
> > Hello,
>
> SNIP
>
> >
> > tools/lib/traceevent/event-parse.h | 3 +-
> > tools/lib/traceevent/parse-filter.c | 432 +++++++++++++++++++++++++-----------
>
> I guess we have plans to actualy use parse-filter.c right? ;-)
>
> AFAICS currently there's no user and could (should?) be omited
> from compilation
>

There's no user in tools/ but there's users outside of tools. If this
is going to be a user space library, then I wouldn't hold it to the
same level that the main kernel has. That is, if there's no internal
users of an interface, that we do not support it.

This library did come from trace-cmd, and trace-cmd does use these
interfaces. I would like to have a single repository for the library,
but that wont happen if we don't support all the interfaces.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/