Re: [PATCH] perf tools: Fix bug for perf kvm report without guestmount.

From: Dongsheng Yang
Date: Sun Dec 08 2013 - 23:14:46 EST


On 12/08/2013 10:42 PM, David Ahern wrote:
On 12/9/13, 8:20 AM, Dongsheng Yang wrote:
How about introduce an option named --guestpid? Then we can make the
usage of perf kvm
more clear:
* perf kvm --guestkallsyms --guestmodules --guestpid
[top|record|report]
This usage is for only one guest and will not resolve the
symbols from other guests.

If there is only 1 guest then there should not be a problem right? You give perf a single guest kallsyms as the "default" and it works. --guestpid adds no value in that case.

Yes, if there is only one guest is running, "default" guest is "the" guest. Then with my patch in this thread applied, it works well.

But consider this scenario, there are two guests are running, but we need to record-report one of them.

--guestmount can achieve this request, but as a shortcut of guestmount, --guest{kallysms, modules} dose not
support it well, right? So, I think we can discard the default guest, and use guestpid in record-report.

David




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/