[PATCH 4/5 linux-next V2] cifs: fix incorrect reference count check

From: Tim Gardner
Date: Sun Dec 08 2013 - 16:09:49 EST


The reference count on tlink can only be decremented if
cifs_sb_tlink(cifs_sb) was used to acquire it. That only
happens if open_file==NULL.

Cc: Steve French <sfrench@xxxxxxxxx>
Cc: Jeff Layton <jlayton@xxxxxxxxxx>
Cc: Dean Gehnert <deang@xxxxxxx>
Signed-off-by: Tim Gardner <timg@xxxxxxx>
---

V2 - this is a new patch in the V2 series.

fs/cifs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 3f710c6..e332038 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -2007,7 +2007,7 @@ cifs_set_file_size(struct inode *inode, struct iattr *attrs,
CIFSSMBClose(xid, tcon, netfid);
}
}
- if (tlink)
+ if (!open_file)
cifs_put_tlink(tlink);

set_size_out:
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/