[PATCH v1 5/6] net: phy: suspend unused PHYs on mdio_bus in late_initcall

From: Sebastian Hesselbarth
Date: Sun Dec 08 2013 - 09:41:26 EST


Since phy_attach ensures PHYs are resumed, we can now suspend all
PHYs that have no attached netdev after initcalls.

Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
Acked-by: Mugunthan V N <mugunthanvnm@xxxxxx>
Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
---
Changelog:
RFCv2->v1:
- simplify phydev reference (Suggested by Sergei Shtylyov)

Cc: David Miller <davem@xxxxxxxxxxxxx>
Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
Cc: Mugunthan V N <mugunthanvnm@xxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
---
drivers/net/phy/mdio_bus.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 5617876..9ccf9c6 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -320,6 +320,29 @@ static int mdio_bus_match(struct device *dev, struct device_driver *drv)
(phydev->phy_id & phydrv->phy_id_mask));
}

+static int mdio_bus_suspend_unused(struct device *busdev, void *data)
+{
+ struct mii_bus *bus = to_mii_bus(busdev);
+ int i;
+
+ for (i = 0; i < PHY_MAX_ADDR; i++) {
+ if (!bus->phy_map[i])
+ continue;
+
+ if (!bus->phy_map[i]->attached_dev)
+ phy_suspend(bus->phy_map[i]);
+ }
+
+ return 0;
+}
+
+static int mdio_bus_class_suspend_unused(void)
+{
+ return class_for_each_device(&mdio_bus_class, NULL, NULL,
+ mdio_bus_suspend_unused);
+}
+late_initcall_sync(mdio_bus_class_suspend_unused);
+
#ifdef CONFIG_PM

static bool mdio_bus_phy_may_suspend(struct phy_device *phydev)
--
1.8.4.rc3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/