Re: [PATCH 1/1] usermodehelper: kill____call_usermodehelper()->set_cpus_allowed_ptr()

[Oleg Nesterov]

Hi Tejun,

On 11/29, Tejun Heo wrote:
>
> Hey, Oleg.
>
> On Thu, Nov 28, 2013 at 08:33:49PM +0100, Oleg Nesterov wrote:
> > @@ -208,13 +208,9 @@ static int ____call_usermodehelper(void *data)
> >  	spin_lock_irq(&current->sighand->siglock);
> >  	flush_signal_handlers(current, 1);
> >  	spin_unlock_irq(&current->sighand->siglock);
> > -
> > -	/* We can run anywhere, unlike our parent keventd(). */
> > -	set_cpus_allowed_ptr(current, cpu_all_mask);
>
> I don't think this is correct on numa machines where unbound workers
> are NUMA-node affine by default.

Aaah, I see. And you even mentioned this before, but I didn't pay
attention.

Thank!

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/