Re: [PATCH] genetlink: Fix uninitialized variable ingenl_validate_assign_mc_groups()

[David Miller]

From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Date: Sat, 23 Nov 2013 13:01:50 +0100

> net/netlink/genetlink.c: In function ʽgenl_validate_assign_mc_groupsʼ:
> net/netlink/genetlink.c:217: warning: ʽerrʼ may be used uninitialized in this
> function
> 
> Commit 2a94fe48f32ccf7321450a2cc07f2b724a444e5b ("genetlink: make multicast
> groups const, prevent abuse") split genl_register_mc_group() in multiple
> functions, but dropped the initialization of err.
> 
> Initialize err to zero to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> Question: Is the for_each_net_rcu() loop in genl_validate_assign_mc_groups()
>           guaranteed to loop at least once?
> 	  If yes, this is a false positive.

Applied, but yes it's a false positive.  There is always &init_net so the
loop always iterates at least once.
N?§²ζμrΈ?yϊθ?Ψb²X¬ΆΗ§vΨ^?)ήΊ{.nΗ+?·??{±?κηzX§Ά?ʽά¨}©?²Ζ zΪ&j:+v?¨Ύ«?κηzZ+?Κ+zf£ʼ·h??§~?­?Ϋi?ϋΰzΉ?w?ʼΈ??¨θ­Ϊ&ʼ)ίʼf?ω^jΗ«y§m?α@A«aΆΪ?0Άμh?ε?i