Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

From: Mark Brown
Date: Thu Nov 28 2013 - 12:14:14 EST


On Tue, Nov 26, 2013 at 01:05:53PM +0000, Charles Keepax wrote:
> On Fri, Nov 08, 2013 at 09:59:28AM -0700, Stephen Warren wrote:

> > That all said, I wonder if the I2C core shouldn't do something like the
> > following inside i2c_add_adapter():
> >
> > if (!adap->dev.of_node && adap->dev.parent)
> > adap->dev.of_node = adap->dev.parent->of_node;

> Should this not also have an of_node_get to increment the ref
> count on the node?

Given that it's pointing to the device that registered the I2C adaptor
it should be able to assume that there's a reference already.

Attachment: signature.asc
Description: Digital signature