Re: [PATCH v3 1/4] perf diff: color the Delta column

[Jiri Olsa]

On Wed, Nov 27, 2013 at 04:32:31PM +0530, Ramkumar Ramachandra wrote:
> Color the numbers in the Delta column either green or red depending on
> whether the number is positive or negative.
> 
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx>
> ---
>  tools/perf/builtin-diff.c | 37 ++++++++++++++++++++++++++++++++++++-
>  1 file changed, 36 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index 3b67ea2..fe6e200 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -769,6 +769,33 @@ static int hpp__entry_baseline(struct hist_entry *he, char *buf, size_t size)
>  	return ret;
>  }
>  
> +static int hpp__color_delta(struct perf_hpp_fmt *fmt,
> +			struct perf_hpp *hpp, struct hist_entry *he)
> +{
> +	struct diff_hpp_fmt *dfmt =
> +		container_of(fmt, struct diff_hpp_fmt, fmt);
> +	struct hist_entry *pair = get_pair_fmt(he, dfmt);
> +	double percent;
> +	char pfmt[20] = " ";
> +
> +	if (!pair)
> +		goto dummy_print;
> +	if (pair->diff.computed)
> +		percent = pair->diff.period_ratio_delta;
> +	else
> +		percent = compute_delta(he, pair);
> +
> +	if (fabs(percent) >= 0.01) {
> +		scnprintf(pfmt, 20, "%%%+d.2f%%%%", dfmt->header_width - 1);
> +		return color_snprintf(hpp->buf, hpp->size,
> +				percent > 0 ? PERF_COLOR_GREEN : PERF_COLOR_RED,

these colors are not consistent with colors in baseline,
moreover all negative values are shown as red

- please check get_percent_color function (used for baseline),
  it checks the percentage against following values:

  #define MIN_GREEN       0.5
  #define MIN_RED         5.0

- you probably want to use that, or whatever other helper
  baseline uses
- also you need to change it to use/check the abs() value
  of the percentage, because it does not count with negative
  values (it's for baseline only so far), which we will get
  in here..


thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/