Re: [PATCH] UAPI linux/fs.h: add a warning about wrong ioctlargument types

From: Aurelien Jarno
Date: Wed Nov 27 2013 - 18:02:44 EST


On Wed, Nov 27, 2013 at 03:13:40AM -0800, Christoph Hellwig wrote:
> Thanks Aurelien,
>
> the added comment looks good and very useful,
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>

Thanks for the review.

> We don't have any man pages documenting these ioctls or other user
> visible documentation, do we?

The only documentation I have found about these ioctls is from the
ioctl_list(2) manpage, but with different name and defined in
<linux/ext2_fs.h>. In any case they are correctly defined:

0x80046601 EXT2_IOC_GETFLAGS int *
0x40046602 EXT2_IOC_SETFLAGS const int *
0x80047601 EXT2_IOC_GETVERSION int *
0x40047602 EXT2_IOC_SETVERSION const int *

--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@xxxxxxxxxxx http://www.aurel32.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/