Re: [PATCH] of/platform: Fix no irq domain found errors whenpopulating interrupts
From: Tony Lindgren
Date: Wed Nov 27 2013 - 16:53:21 EST
* Grant Likely <grant.likely@xxxxxxxxxx> [131124 13:37]:
>
> I actually like the idea of completely allocating the resource structure
> but leaving some entries empty. However, I agree with rmk that putting
> garbage into a resource structure is a bad idea. What about changing the
> value of flags to 0 or some other value to be obviously an empty
> property and give the follow up parsing some context about which ones it
> needs to attempt to recalculate?
If we want to play it safe, we should probably introduce something like
this to ioport.h:
+#define IORESOURCE_IRQ_DEFERRED (1<<6)
Then we can populate IRQ resources initially with that. And later on
during the driver probe, we know it's safe to populate the resource
if res->flags & IORESOURCE_IRQ_DEFERRED.
That fixes the $Subject bug, and gets us a little bit further for
making more changes later on.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/