Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver forMaxim 14577

[Lee Jones]

On Wed, 27 Nov 2013, Mark Brown wrote:

> On Wed, Nov 27, 2013 at 03:23:58PM +0000, Lee Jones wrote:
> > On Wed, 27 Nov 2013, Mark Brown wrote:
> > > > +	{
> > > > +		.name = "max14577-regulator",
> > > > +		.of_compatible = "maxim,max14577-regulator",
> > > > +	},
> 
> > > Why is there a compatible for this at all, would this ever appear as
> > > part of a different device?
> 
> > For automatic assigning of it's of_node.
> 
> > In previous incarnations of this set it was done manually for some reason.
> 
> The usual thing to do is of_get_child_by_name() on the parent to get the
> container to search in.

What do you mean when you say 'usual thing'? Only the max8998 does
this currently. IMHO the better way to do it for MFD devices is
provide a compatible string and let the framework does the rest for
you.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/