Re: [PATCH 1/9] dt: Handle passed/built-in DT selection in early_init_dt_scan()

[Grant Likely]

On Thu, 21 Nov 2013 18:42:58 +0100, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Thu, Nov 21, 2013 at 6:38 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:
> > I really don't like saying one arch can have built-in dtb and another
> > one can't. Either we allow it or we don't. If this is a bad feature,
> > then why did we let multiple arches implement it.
> 
> ... and did we put it in asm-generic, so now _every_ arch has __dtb_start.
> 
> Gr{oetje,eeting}s,

Some platforms need it because they either don't have bootloader
support, they couldn't change the boot interface, or they don't have a
bootwrapper they can put it in. I'd rather have it in common code than a
different implementation on each architecture.

For the copy flag, it would be fine to put an "if (IS_CONFIGURED())"
test around the copy block so that it never happens on some
architectures.

g.

> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/