Re: [PATCH 21/25] perf evsel: Skip ignored symbols while printingcallchain

[David Ahern]

On 11/26/13, 7:20 AM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 26, 2013 at 12:52:21PM +0200, Adrian Hunter escreveu:
> > On 25/11/13 16:17, Arnaldo Carvalho de Melo wrote:
> > > From: David Ahern <dsahern@xxxxxxxxx>
> > >   	} else {
> > > +		if (al.sym->ignore)
> >
> > Seems to segfault here because sym is null
> >
> > > +			return;
> > > +
>
> Changed it to look at (al.sym && al.sym->ignore), the rest of the code
> already checkfs if al.sym is NULL (printing [unknown], etc), can you
> please take a look at:
>
> https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=c0dd57452349779e0e5d436db8f9448dfffcc512
>
> In an updated acme/perf/core branch?

Looks good to me. That's what I was going to send you. Sorry for the noise.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/