Re: [PATCH 0/3 v3] build in panic_timeout value

From: Ingo Molnar
Date: Tue Nov 26 2013 - 06:17:20 EST



* Jason Baron <jbaron@xxxxxxxxxx> wrote:

> Hi,
>
> I've now separated out the arch bits into separate patches.
> Hopefully, it makes review easier. I also didn't address moving the
> 'panic_timeout' command-line parameter up as an 'early_param()'. I
> think it might make sense to move it up, especially for distro
> kernels, but its not a need here, so I didn't want to just shove it
> in. If needed, I think it can come in separately, as it shoudn't
> affect this series.

The series looks good to me, I've applied the patches to
tip:core/debug.

If Felipe Contreras's fix patch looks good to you then it would also
be nice if you could send me that as well, on top of your patches.

That fix patch had only one remaining bug/problem, last I checked: if
panic_timeout is turned into an early_param() then pause_on_oops
should obviously also be turned into an early param. Changing just one
of these parameters would be inconsistent and would lead to assymetric
behavior in the early-crash case.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/