Re: [PATCH 06/12] mtd: nand: davinci: adjust DT properties to MTDgeneric

[ivan.khoronzhuk]

On 11/26/2013 12:30 PM, Grygorii Strashko wrote:
> On 11/26/2013 09:03 AM, Sekhar Nori wrote:
> > On Monday 11 November 2013 10:31 PM, Khoronzhuk, Ivan wrote:
> > > The properties davinci-ecc-mode, davinci-nand-use-bbt, davinci-nand-buswidth
> > > are MTD generic. Correct names for them are: nand-ecc-mode, nand-on-flash-bbt,
> > > nand-bus-width accordingly. So rename them in dts and documentation.
> > >
> > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxx>
> > > ---
> > >    .../devicetree/bindings/mtd/davinci-nand.txt       |   25 ++++++++++++++++----
> > >    drivers/mtd/nand/davinci_nand.c                    |   11 ++++++---
> > >    2 files changed, 28 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mtd/davinci-nand.txt b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> > > index d2a3fc0..befaa5b 100644
> > > --- a/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> > > +++ b/Documentation/devicetree/bindings/mtd/davinci-nand.txt
> > > @@ -37,7 +37,7 @@ Recommended properties :
> > >    - ti,davinci-mask-chipsel:     mask for chipselect address. Needed to mask
> > >                                   addresses for given chipselect.
> > >
> > > -- ti,davinci-ecc-mode:         operation mode of the NAND ecc mode. ECC mode
> > > +- nand-ecc-mode:               operation mode of the NAND ecc mode. ECC mode
> > >                                   valid values for davinci driver:
> > >                                   - "none"
> > >                                   - "soft"
> > > @@ -45,10 +45,25 @@ Recommended properties :
> > >
> > >    - ti,davinci-ecc-bits:         used ECC bits, currently supported 1 or 4.
> > >
> > > -- ti,davinci-nand-buswidth:    buswidth 8 or 16.
> >
> > Shouldn't we keep the documentation for existing bindings while just
> > marking them as deprecated?
>
> I haven't found any requirements about this in doc.
> It's done in both way in other drivers - some keep properties in bindings
> documentation and some are not.
>
> Regards,
> -grygorii

For me this is not needed, but for example from mtd:
Documentation/devicetree/bindings/mtd/gpmc-nand.txt
,it contains deprecated properties, like a lot of others.

And this sad me I should remain deprecated properties.
Anyway if we have these properties in driver we should describe them.

--
Regards,
Ivan Khoronzhuk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/