Re: [PATCH] dt-bindings: add ARMv8 PMU binding

[Mark Rutland]

On Fri, Nov 22, 2013 at 09:43:31PM +0000, Rob Herring wrote:
> On 11/22/2013 03:38 PM, Kumar Gala wrote:
> > 
> > On Nov 22, 2013, at 3:17 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:
> > 
> >> From: Rob Herring <rob.herring@xxxxxxxxxxx>
> >>
> >> Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.
> >>
> >> Signed-off-by: Rob Herring <rob.herring@xxxxxxxxxxx>
> >> Cc: Will Deacon <will.deacon@xxxxxxx>
> >> Cc: Pawel Moll <pawel.moll@xxxxxxx>
> >> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> >> Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
> >> ---
> >> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
> >> index 343781b..3e1e498 100644
> >> --- a/Documentation/devicetree/bindings/arm/pmu.txt
> >> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
> >> @@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
> >> Required properties:
> >>
> >> - compatible : should be one of
> >> +	"arm,armv8-pmuv3â
> > 
> > what about arm,armv8-pmu-v3?
> 
> I'm just documenting what is already being used:
> 
> arch/arm64/boot/dts/foundation-v8.dts:          compatible =
> "arm,armv8-pmuv3";
> arch/arm64/boot/dts/rtsm_ve-aemv8a.dts:         compatible =
> "arm,armv8-pmuv3";
> 
> Do we want to change those?

It would probably have been nicer to have the '-' from the start, but
adding it now is only going to expand the set of compatible strings for
no appreciable benefit.

I don't see any value in adding a new form of the string, and we can't
change the existing one as it's already in use.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/