Re: Large pastes into readline enabled programs causes breakage fromv2.6.31 onwards

[Peter Hurley]

On 11/23/2013 07:29 PM, One Thousand Gnomes wrote:
> > 7) Rescan line discipline buffer when changing from non-canonical to canonical
> > mode. The real problem with this approach (besides the inefficiency) is that this
> > solution could break some (admittedly unknown) program that contrived to exchange
> > data in non-canonical mode but read in canonical mode (just not exceeding the
> > line discipline buffer limit).
>
> See bugzilla 55981, 55991 btw

Thanks for the bug references, Alan.

The solution proposed in 55991 (to perform an EOF push when switching from
non-canon to canon) would further break paste to readline().

The caller to readline() may not actually perform any read() but may
simply loop, calling readline();  in this case, when readline()
switches back to non-canonical, it will eventually read the inserted '\0'.
That would be bad.

Regards,
Peter Hurley


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/