Re: [PATCH 1/2] ARM: ux500: decomission the non-DT MTU init sequence

From: Linus Walleij
Date: Tue Nov 19 2013 - 17:55:34 EST


On Tue, Nov 19, 2013 at 11:40 PM, Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:
> On 11/19/2013 10:27 PM, Linus Walleij wrote:

>> - if (!of_have_populated_dt())
>> - nmdk_timer_init(mtu_timer_base, IRQ_MTU0);
>
> If no timer have been defined in the dt [or wrongly defined], is there a
> message to tell the user what is wrong ?

Isn't that a question to be asked about a whole lot of such
clocksource drivers and ARM platforms?

Most DT-only ARM platforms rely on
arch/arm/kernel/time.c to call clocksource_of_init() if the
machine_desc->init_time() hook is not set and has zero
code to handle any such situation.

So I guess what you're asking is whether we should patch
clocksource_of_init() to warn if it cannot find any
matching clock sources, like this: