Re: [PATCH 17/24] ocfs2: Convert use of typedef ctl_table to structctl_table

From: Joel Becker
Date: Thu Nov 07 2013 - 06:06:58 EST


On Tue, Oct 22, 2013 at 03:30:00PM -0700, Joe Perches wrote:
> This typedef is unnecessary and should just be removed.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Acked-by: Joel Becker <jlbec@xxxxxxxxxxxx>
> ---
> fs/ocfs2/stackglue.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ocfs2/stackglue.c b/fs/ocfs2/stackglue.c
> index 39abf89..cb7ec0b 100644
> --- a/fs/ocfs2/stackglue.c
> +++ b/fs/ocfs2/stackglue.c
> @@ -643,7 +643,7 @@ error:
>
> #define FS_OCFS2_NM 1
>
> -static ctl_table ocfs2_nm_table[] = {
> +static struct ctl_table ocfs2_nm_table[] = {
> {
> .procname = "hb_ctl_path",
> .data = ocfs2_hb_ctl_path,
> @@ -654,7 +654,7 @@ static ctl_table ocfs2_nm_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_mod_table[] = {
> +static struct ctl_table ocfs2_mod_table[] = {
> {
> .procname = "nm",
> .data = NULL,
> @@ -665,7 +665,7 @@ static ctl_table ocfs2_mod_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_kern_table[] = {
> +static struct ctl_table ocfs2_kern_table[] = {
> {
> .procname = "ocfs2",
> .data = NULL,
> @@ -676,7 +676,7 @@ static ctl_table ocfs2_kern_table[] = {
> { }
> };
>
> -static ctl_table ocfs2_root_table[] = {
> +static struct ctl_table ocfs2_root_table[] = {
> {
> .procname = "fs",
> .data = NULL,
> --
> 1.8.1.2.459.gbcd45b4.dirty
>

--

Life's Little Instruction Book #451

"Don't be afraid to say, 'I'm sorry.'"

http://www.jlbec.org/
jlbec@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/