Re: [PATCH 05/11] ARM: Introduce CPU_METHOD_OF_DECLARE() for cpuhotplug/smp

From: Stephen Boyd
Date: Tue Nov 05 2013 - 12:27:25 EST


On 11/05/13 09:24, Kumar Gala wrote:
> On Nov 1, 2013, at 5:08 PM, Stephen Boyd wrote:
>
>> @@ -150,8 +182,14 @@ void __init arm_dt_init_cpu_maps(void)
>> }
>>
>> tmp_map[i] = hwid;
>> +
>> + if (!found_method)
>> + found_method = set_smp_ops_by_method(cpu);
>> }
>>
>> + if (!found_method)
>> + set_smp_ops_by_method(cpus);
>> +
> I assume this if for the case that the enable method is in the cpus{ } container but not in a specific cpu node?
>
> If so, the binding is not clear that we allow this. Also a comment would probably be nice.

Sure I'll add a comment to that effect and clarify the binding.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/