Re: [PATCH 01/28] dmaengine: use DMA_COMPLETE for dma completionstatus

From: Sebastian Andrzej Siewior
Date: Mon Nov 04 2013 - 07:52:10 EST


On 30.10.13, Vinod Koul wrote:
> I fixed up the error with below, can you pls verify. Pls note this is compile
> tested only!

I tested this and my mmc driver using edma via drivers/dma seems to
work.
Tested-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

However you missed one piece:

CC [M] sound/soc/davinci/davinci-pcm.o
sound/soc/davinci/davinci-pcm.c: In function âdavinci_pcm_dma_irqâ:
sound/soc/davinci/davinci-pcm.c:241: error: âDMA_COMPLETEâ undeclared (first use in this function)
sound/soc/davinci/davinci-pcm.c:241: error: (Each undeclared identifier is reported only once
sound/soc/davinci/davinci-pcm.c:241: error: for each function it appears in.)

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
---
sound/soc/davinci/davinci-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/davinci/davinci-pcm.c b/sound/soc/davinci/davinci-pcm.c
index 8460edc..e68ba31 100644
--- a/sound/soc/davinci/davinci-pcm.c
+++ b/sound/soc/davinci/davinci-pcm.c
@@ -238,7 +238,7 @@ static void davinci_pcm_dma_irq(unsigned link, u16 ch_status, void *data)
print_buf_info(prtd->ram_channel, "i ram_channel");
pr_debug("davinci_pcm: link=%d, status=0x%x\n", link, ch_status);

- if (unlikely(ch_status != DMA_COMPLETE))
+ if (unlikely(ch_status != EDMA_DMA_COMPLETE))
return;

if (snd_pcm_running(substream)) {
--
1.8.4.rc3

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/