Re: [PATCH driver-core-next] sysfs: use generic_file_llseek() forsysfs_file_operations

From: Heiko Carstens
Date: Fri Nov 01 2013 - 14:42:01 EST


On Fri, Nov 01, 2013 at 10:19:13AM -0700, Greg Kroah-Hartman wrote:
> On Fri, Nov 01, 2013 at 01:16:53PM -0400, Tejun Heo wrote:
> > Hey, Greg.
> >
> > Here's proper patch with description and SOB. I'll be traveling from
> > tomorrow so I might not be responsive for some days. Can you please
> > apply it once Heiko confirms it fixes the issue?
>
> Will do.
>
> Heiko, let me know if this fixes your problem or not, thanks.

Yes it does fix the problem. strace output looks like before:

[pid 2495] open("/sys/class/net/eth0/broadcast", O_RDONLY) = 5
[pid 2495] lseek(5, 0, SEEK_END) = 4096
[pid 2495] lseek(5, 0, SEEK_SET) = 0
[pid 2495] read(5, "ff:ff:ff:ff:ff:ff\n", 4096) = 18
[pid 2495] close(5) = 0

Tested-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/