Re: [PATCH 2/6] perf timechart: use proc_num to implement --power-only

From: Namhyung Kim
Date: Fri Nov 01 2013 - 02:07:24 EST


On Tue, 29 Oct 2013 13:28:46 +0400, Stanislav Fomichev wrote:
>> I don't see how it does same thing. You mean it by skipping
>> draw_process_bars() and draw_wakeups() on patch 1? It'd be better
>> changelog explains the details.
> Yes, it depends on the previous patch, I'll add more info to the
> changelog.

If so, I think it'd better moving the if () parts into this patch.

Thanks,
Namhyung

>
>> And I'd like to keep it as BOOLEAN option - it's simpler and more
>> straight-forward IMHO.
>>
>> How about adding
>>
>> if (power_only)
>> proc_num = 0;
>>
>> after parsing the command line options?
> Ok, this works too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/