Re: [PATCH] netfilter: fix ordering of jumpstack allocation andtable update

From: Will Deacon
Date: Mon Oct 21 2013 - 08:15:10 EST


On Fri, Oct 18, 2013 at 06:18:13PM +0100, Eric Dumazet wrote:
> On Fri, 2013-10-18 at 17:57 +0100, Will Deacon wrote:
> > Hi Pablo,
> >
>
> > > We also need fixes for net/ipv6/netfilter/ip6_tables.c and
> > > net/ipv4/netfilter/arp_tables.c as well. Could you extend this patch
> > > and resend?
> >
> > Sure, I can try, but that's going to require a bit of time to sit down and
> > look at the shared data, access order, dependencies etc. I'm currently
> > preparing for Edinburgh, so it might be a while before I get a chance to
> > extend this.
>
> That's basically same code copy/pasted, so it should be relatively easy.

Ok, I took a look and I think I see what you mean: there are just some
additional consumers of the tables, so there aren't any additional writers
afaict (at least, net/bridge/netfilter/ebtables.c uses rw locks so we don't
have an issue there).

Attempt at an updated patch below.

Cheers,

Will

--->8