Re: [PATCH] carl9170: fix leaks at failure path in carl9170_usb_probe()

[Fabio Estevam]

On Sat, Sep 28, 2013 at 12:51 AM, Alexey Khoroshilov
<khoroshilov@xxxxxxxxx> wrote:

> -       return request_firmware_nowait(THIS_MODULE, 1, CARL9170FW_NAME,
> +       err = request_firmware_nowait(THIS_MODULE, 1, CARL9170FW_NAME,
>                 &ar->udev->dev, GFP_KERNEL, ar, carl9170_usb_firmware_step2);
> +       if (err) {
> +               usb_put_dev(udev);
> +               usb_put_dev(udev);

You are doing the same free twice.

I guess you meant to also free: usb_put_dev(ar->udev)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/