Re: [PATCH] Staging: sm7xxfb: fixed line break coding style issues

From: Greg KH
Date: Fri Sep 27 2013 - 11:41:22 EST


On Fri, Sep 27, 2013 at 05:39:11PM +0200, Martin Berglund wrote:
> On Fri, Sep 27, 2013 at 03:27:29PM +0300, Dan Carpenter wrote:
> > On Fri, Sep 27, 2013 at 02:08:07PM +0200, Martin Berglund wrote:
> > > @@ -508,9 +506,8 @@ static void sm7xx_set_timing(struct smtcfb_info *sfb)
> > >
> > > /* init SEQ register SR30 - SR75 */
> > > for (i = 0; i < SIZE_SR30_SR75; i++)
> > > - if (((i + 0x30) != 0x62) \
> > > - && ((i + 0x30) != 0x6a) \
> > > - && ((i + 0x30) != 0x6b))
> > > + if (((i + 0x30) != 0x62) && ((i + 0x30) != 0x6a)
> > > + && ((i + 0x30) != 0x6b))
> >
> > The prefered way would be to align this like this:
> >
> > if ((i + 0x30) != 0x62 &&
> > (i + 0x30) != 0x6a &&
> > (i + 0x30) != 0x6b)
> >
> > regards,
> > dan carpenter
> >
>
> New patch.
>
> Signed-off-by: Martin Berglund <martin@xxxxxxxxxx>

Can you please resend this in a format I can apply it in, without
needing to edit the patch body by hand? I deal with thousands of
patches every month, and if I have to edit them all, that cuts down my
ability to apply them greatly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/