Re: [PATCH 1/4] [RFC] net: Explicitly initialize u64_stats_syncstructures for lockdep

[Eric Dumazet]

On Fri, 2013-09-27 at 07:44 +0200, Ingo Molnar wrote:

> C cannot pass along symbolic names, unfortunately, so we are stuck with 
> 1970's tech and the C preprocessor.
> 

Yes, I realized that a bit too late.

> There's a way to make such macros look a tiny bit more structured and thus 
> be more palatable:
> 
> #if BITS_PER_LONG == 32 && defined(CONFIG_SMP)
> # define u64_stats_init(syncp) seqcount_init(syncp.seq)
> #else
> # define u64_stats_init(syncp)
> #endif
> 
> Note, the 'else' branch should probably be:
> 
> # define u64_stats_init(syncp) do { } while (0)

Yes, this is better ;)

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/