Re: [tip:x86/reboot] x86/reboot: Remove the duplicate C6100 entry inthe reboot quirks list

[Ingo Molnar]

* H. Peter Anvin <hpa@xxxxxxxxx> wrote:

> On 09/26/2013 01:59 PM, Davidlohr Bueso wrote:
> >> -	},
> >> -	{	/* Some C6100 machines were shipped with vendor being 'Dell'. */
> >> -		.callback = set_pci_reboot,
> >> -		.ident = "Dell PowerEdge C6100",
> >> -		.matches = {
> >>  			DMI_MATCH(DMI_SYS_VENDOR, "Dell"),
> >>  			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> >>  		},
> > 
> > Hmm, I think we should be keeping the 'Dell Inc.' part instead of just
> > 'Dell' - at least the rest of the entries use the same string:
> > 
> 
> The point is that some of the machines just has "Dell" in their vendor
> string.

Yes, so if then the argument could be made that all the other entries 
should probably be changed to 'Dell' as well.

This is yet another reminder that DMI matches are such a fragile method 
...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/