Re: perf, x86: Add last TSX PMU code for Haswell v2

[Jiri Olsa]

On Fri, Sep 20, 2013 at 07:40:38AM -0700, Andi Kleen wrote:
> [This has kernel and user parts, so will need
> review/ack/merges from both perf kernel and user land maintainers]
> [v2: Address Peter's feedback for the kernel parts]
> 
> This is currently the last part of the TSX PMU code,
> just adding the left over bits:
> 
> This adds some changes to the user interfaces.
> I'll send patches for the manpage separately.
> 
> - Report the transaction abort flags to user space
> using a new field, and add the code to display them.
> This is used to classify abort types, also fairly
> important for tuning as it guides the tuning process,
> together with the abort weight that was added earleir.
> 
> [3 patches, generic, x86, user tools]
> 
> - Add support for reporting the two new TSX LBR flags: in_tx
> and abort_tx. The code to handle the LBRs was already
> added earlier, this just adds the code to report,
> filter and display them.
> 
> - Add a workaround for a Haswell issue that it reports
> an extra LBR record for every abort. We just filter
> those out in the kernel.
> 
> Open perf TSX issues left:
> - Revisit automatic enabling of precise for tx/el-abort
> - Need to fix the sort handling in the user tools
> to actually sort on other fields
> - The aggregated LBR display in the user tools is not 
> very useful for transactions, need a way to report them 
> in a histogram like backtraces.
> - May want some shortcut options for
> record --transaction --weight / report --sort symbol,transaction,weight
> 
> -Andi

I checked and tried (with no actuall data.. have no Haswell server)
and it seems ok

for the perf tool part:
Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>


thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/